fix(build): save assets and scenes before BuildPlayer - #1340
Merged
Conversation
Prevent manage_build from blocking on Unity's unsaved-scene dialog by calling AssetDatabase.SaveAssets and EditorSceneManager.SaveOpenScenes before BuildPipeline.BuildPlayer runs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
14 tasks
singam96
added a commit
to singam96/unity-mcp
that referenced
this pull request
Aug 30, 2026
Collaborator
|
Thanks! |
Scriptwonder
added a commit
that referenced
this pull request
Aug 31, 2026
#1340 added SaveBeforeBuild() so manage_build would not block on Unity's unsaved-scene dialog, but it called EditorSceneManager.SaveOpenScenes() unconditionally. A scene that has never been saved carries an empty path, and handing one to Unity's save API opens the modal "Save Scene" file panel -- the exact block the change was meant to prevent. The warning it logs fires only after SaveOpenScenes() returns, which is after the modal has already stalled the main thread. Saves dirty scenes individually and skips pathless ones with a warning, mirroring the guard TestRunnerService.SaveDirtyScenes has carried since it hit the same problem. ManageScene refuses the same case at ManageScene.cs:492. Follow-up to #1340. Refs #1341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1341
Summary
AssetDatabase.SaveAssets()andEditorSceneManager.SaveOpenScenes()inBuildRunnerbeforeBuildPipeline.BuildPlayerrunsmanage_buildfrom blocking on Unity's unsaved-scene save dialog when scenes or assets were modifiedTest plan
manage_buildwith actionbuild